[ 
https://issues.apache.org/jira/browse/DISPATCH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361400#comment-16361400
 ] 

ASF GitHub Bot commented on DISPATCH-911:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/247#discussion_r167675656
  
    --- Diff: src/router_core/agent_address.c ---
    @@ -54,6 +56,8 @@ const char *qdr_address_columns[] =
          "deliveriesTransit",
          "deliveriesToContainer",
          "deliveriesFromContainer",
    +     "deliveriesToRouteContainer",
    +     "deliveriesFromRouteContainer",
    --- End diff --
    
    I find the names of these two new attributes misleading.  They appear to be 
grouped with the former two attributes "deliveriesToContainer" and 
"deliveriesFromContainer" because of the similar naming.  The new stats are 
supposed to be grouped with "deliveriesIngress" and "deliveriesEgress".  I 
think better names would be "deliveriesIngressRouteContainer" and 
"deliveriesEgressRouteContainer".


> Add link and address level counters at the global router level
> --------------------------------------------------------------
>
>                 Key: DISPATCH-911
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-911
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Management Agent
>    Affects Versions: 1.0.0
>            Reporter: Ernest Allen
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.1.0
>
>
> Link already has the following counters - 
>  presettledCount
>  droppedPresettledCount
>  acceptedCount
>  rejectedCount
>  releasedCount
>  modifiedCount
> Address already has the following counters
>  deliveriesIngress
>  deliveriesEgress
>  deliveriesTransit
> 1. Add the above link and address counters to the global router level as well.
>  2. Add routeContainerDeliveriesEgress and routeContainerDeliveriesIngress as 
> address and global counters
>  3. Add router memory footprint as a global statistic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to