[ 
https://issues.apache.org/jira/browse/DISPATCH-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364151#comment-16364151
 ] 

ASF GitHub Bot commented on DISPATCH-911:
-----------------------------------------

Github user ganeshmurthy commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/254#discussion_r168192351
  
    --- Diff: src/router_node.c ---
    @@ -33,7 +33,6 @@
     const char *QD_ROUTER_NODE_TYPE = "router.node";
     const char *QD_ROUTER_ADDRESS_TYPE = "router.address";
     const char *QD_ROUTER_LINK_TYPE = "router.link";
    -const char *CORE_AGENT_ADDRESS = "$management";
    --- End diff --
    
    You are correct. This is not related to the PR. I saw that this was not 
being used anywhere, so I removed it. 


> Add link and address level counters at the global router level
> --------------------------------------------------------------
>
>                 Key: DISPATCH-911
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-911
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Management Agent
>    Affects Versions: 1.0.0
>            Reporter: Ernest Allen
>            Assignee: Ganesh Murthy
>            Priority: Major
>             Fix For: 1.1.0
>
>
> Link already has the following counters - 
>  presettledCount
>  droppedPresettledCount
>  acceptedCount
>  rejectedCount
>  releasedCount
>  modifiedCount
> Address already has the following counters
>  deliveriesIngress
>  deliveriesEgress
>  deliveriesTransit
> 1. Add the above link and address counters to the global router level as well.
>  2. Add routeContainerDeliveriesEgress and routeContainerDeliveriesIngress as 
> address and global counters
>  3. Add router memory footprint as a global statistic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to