[
https://issues.apache.org/jira/browse/PROTON-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511080#comment-16511080
]
ASF subversion and git services commented on PROTON-1856:
---------------------------------------------------------
Commit c7205a63db7d14e209d627be9be8314a49536e57 in qpid-proton's branch
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7205a6 ]
PROTON-1856: [ruby] auto_accept overwriting user state
MessagomgAdapter was incorrectly checking settled? to determine if the local
handler had settled a transfer, but #settled? returns the *remote* state. For a
delivery that was not yet settled remotely, this would over-write the state set
by the user handler.
Check for local_state == 0 instead.
> [ruby] auto-accept over-writing user transfer state
> ---------------------------------------------------
>
> Key: PROTON-1856
> URL: https://issues.apache.org/jira/browse/PROTON-1856
> Project: Qpid Proton
> Issue Type: Bug
> Components: ruby-binding
> Affects Versions: proton-c-0.23.0
> Reporter: Alan Conway
> Assignee: Alan Conway
> Priority: Major
> Fix For: proton-c-0.24.0
>
>
> The auto-accept functionality of the MessagingAdapter is incorrectly setting
> the transfer state even if the user had already set it. It is checking for
> "settled?" to decide if it should set state, but this is incorrect since the
> message may be locally but not remotely settled at this point.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
