[ 
https://issues.apache.org/jira/browse/PROTON-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16511081#comment-16511081
 ] 

ASF subversion and git services commented on PROTON-1859:
---------------------------------------------------------

Commit 5bc84443c4092286e2447a522a08014295d484c8 in qpid-proton's branch 
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5bc8444 ]

PROTON-1859: [cpp] auto-accept over-writing user transfer state

messaging_adapter was incorrectly checking settled() to determine if the local
handler had settled a transfer, settled() returns the *remote* state. For a
delivery that was not yet settled remotely, this would over-write the state set
by the user handler.

Check for local_state == 0 instead.


> [cpp] auto-accept over-writing user transfer state
> --------------------------------------------------
>
>                 Key: PROTON-1859
>                 URL: https://issues.apache.org/jira/browse/PROTON-1859
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: ruby-binding
>    Affects Versions: proton-c-0.23.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>            Priority: Major
>             Fix For: proton-c-0.24.0
>
>
> The auto-accept functionality of the messaging_adpater is incorrectly setting 
> the transfer state even if the user had already set it. It is checking for 
> "settled" to decide if it should set state, but this is incorrect on the 
> server side since the message may be locally but not remotely settled at this 
> point.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to