[
https://issues.apache.org/jira/browse/PROTON-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568047#comment-16568047
]
ASF GitHub Bot commented on PROTON-1886:
----------------------------------------
GitHub user k-wall opened a pull request:
https://github.com/apache/qpid-proton/pull/152
PROTON-1886: Dump the thread's SSL error queue in the event that SSL_new
fails.
Uses the established mechanism to dump the thread's SSL error queue to
established tracer in the event that SSL_new fails.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/k-wall/qpid-proton master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit f2ae028f534d37abc6856ce21146c70635203628
Author: Keith Wall <kwall@...>
Date: 2018-08-03T09:29:22Z
PROTON-1886: Dump the thread's SSL error queue in the event that SSL_new
fails.
----
> Expose diagnostic information from the openssl error queue when SSL_new fails.
> ------------------------------------------------------------------------------
>
> Key: PROTON-1886
> URL: https://issues.apache.org/jira/browse/PROTON-1886
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Keith Wall
> Priority: Major
>
> If Proton C's call to
> [SSL_new()|https://github.com/apache/qpid-proton/blob/3cb7a5c672d9f817a498684ac7057bcccc713eda/c/src/ssl/openssl.c#L1235]
> fails currently proton logs only "SSL socket setup failure.". It would aid
> diagnostics if the logged information revealed the underlying reason(s) why
> the failure occurred from the openssl error queue/stack. This approach is
> suggested by the openssl SSL_new documentation.
> [https://www.openssl.org/docs/man1.0.2/ssl/SSL_new.html]
> [https://www.openssl.org/docs/manmaster/man3/ERR_get_error.html]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
