[
https://issues.apache.org/jira/browse/PROTON-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587527#comment-16587527
]
ASF GitHub Bot commented on PROTON-1886:
----------------------------------------
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/152
This looks good - I'll pull it in.
I wonder though if there is scope for some refactoring of the ssl error
logic to make this error logic in common.
> Expose diagnostic information from the openssl error queue when SSL_new fails.
> ------------------------------------------------------------------------------
>
> Key: PROTON-1886
> URL: https://issues.apache.org/jira/browse/PROTON-1886
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Reporter: Keith Wall
> Priority: Major
>
> If Proton C's call to
> [SSL_new()|https://github.com/apache/qpid-proton/blob/3cb7a5c672d9f817a498684ac7057bcccc713eda/c/src/ssl/openssl.c#L1235]
> fails currently proton logs only "SSL socket setup failure.". It would aid
> diagnostics if the logged information revealed the underlying reason(s) why
> the failure occurred from the openssl error queue/stack. This approach is
> suggested by the openssl SSL_new documentation.
> [https://www.openssl.org/docs/man1.0.2/ssl/SSL_new.html]
> [https://www.openssl.org/docs/manmaster/man3/ERR_get_error.html]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
