On 08/08/18 11:49, Keith W wrote:
I don't think the Dispatch Router's code or documentation makes it
clear if libwebsockets optional or mandatory at the moment. I believe
from DISPATCH-893 it is the latter.
At least until recently, it was optional.
Furthermore, Cmake is not
programmatically enforcing the libwebsockets >= 2.1.0 restriction.
Here are the details.
1) README does not mention libwebsockets as a dependency so I'd
believe it optional.
2) In CMakeLists.txt, the include(FindLibWebSockets) appears beneath a
comment "Optional dependencies"
However, it you build on a system without libwebsockets-devel
installed, cmake reports the absence as a message and then contiunues:
-- Could NOT find LIBWEBSOCKETS (missing:
LIBWEBSOCKETS_VERSION_STRING LIBWEBSOCKETS_LIBRARIES
LIBWEBSOCKETS_INCLUDE_DIRS)
only for make to fail:
[ 96%] Building C object src/CMakeFiles/qpid-dispatch.dir/http-libwebsockets.c.o
/build/qpid-dispatch-src/src/http-libwebsockets.c:27:27: fatal error:
libwebsockets.h: No such file or directory
#include <libwebsockets.h>
^
compilation terminated.
Just to check, was this on a clean build? Was the libwebsockets package
installed? (i.e. is it where the libs exist but not the headers?)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
