It should be optional, it works for me. Note that cmake only runs library finding logic on the first run, so you need to delete your CMakeCache.txt between experiments.
If you're still seeing problems, please raise a JIRA with platform details, cmake output and cmake version. cmake's library finding stuff has an unstable history, it may be an issue with older cmake that we need to work around. On Wed, Aug 8, 2018 at 7:20 AM, Keith W <[email protected]> wrote: > On Wed, 8 Aug 2018 at 11:58, Gordon Sim <[email protected]> wrote: > > > > On 08/08/18 11:49, Keith W wrote: > > > I don't think the Dispatch Router's code or documentation makes it > > > clear if libwebsockets optional or mandatory at the moment. I believe > > > from DISPATCH-893 it is the latter. > > > > At least until recently, it was optional. > > > > > Furthermore, Cmake is not > > > programmatically enforcing the libwebsockets >= 2.1.0 restriction. > > > > > > Here are the details. > > > > > > 1) README does not mention libwebsockets as a dependency so I'd > > > believe it optional. > > > 2) In CMakeLists.txt, the include(FindLibWebSockets) appears beneath a > > > comment "Optional dependencies" > > > > > > However, it you build on a system without libwebsockets-devel > > > installed, cmake reports the absence as a message and then contiunues: > > > > > > -- Could NOT find LIBWEBSOCKETS (missing: > > > LIBWEBSOCKETS_VERSION_STRING LIBWEBSOCKETS_LIBRARIES > > > LIBWEBSOCKETS_INCLUDE_DIRS) > > > > > > only for make to fail: > > > > > > [ 96%] Building C object src/CMakeFiles/qpid-dispatch. > dir/http-libwebsockets.c.o > > > /build/qpid-dispatch-src/src/http-libwebsockets.c:27:27: fatal error: > > > libwebsockets.h: No such file or directory > > > #include <libwebsockets.h> > > > ^ > > > compilation terminated. > > > > Just to check, was this on a clean build? Was the libwebsockets package > > installed? (i.e. is it where the libs exist but not the headers?) > > > > Each experiment was in clean container. For the first neither > libwebsockets nor libwebsockets-devel were installed. For the second, > I had installed libwebsockets-devel which brings libwebsockets too. > I was using CentOS7. I now know that an RPM for libwebsockets 2.1.0 > for that distribution is not available from the standard channels. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
