[ 
https://issues.apache.org/jira/browse/DISPATCH-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576443#comment-16576443
 ] 

ASF GitHub Bot commented on DISPATCH-1099:
------------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/357#discussion_r209297255
  
    --- Diff: src/router_core/transfer.c ---
    @@ -717,6 +725,35 @@ void qdr_delivery_decref_CT(qdr_core_t *core, 
qdr_delivery_t *dlv, const char *l
             qdr_delete_delivery_internal_CT(core, dlv);
     }
     
    +static void qdr_process_tick_CT(qdr_core_t *core, qdr_action_t *action, 
bool discard)
    +{
    +    if (discard)
    +        return;
    +
    +    if (DEQ_SIZE(core->timer_list) == 0)
    +        return;
    --- End diff --
    
    This check is not needed.  If the timer list is empty, the while loop below 
will exit immediately.


> Add a timer facility for the core thread
> ----------------------------------------
>
>                 Key: DISPATCH-1099
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1099
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.2.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> Currently there is qd_router_timer_handler() in router_node.c which schedules 
> a timer every second/ Extend this to send the timer action into core so core 
> can execute some periodic actions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to