[ 
https://issues.apache.org/jira/browse/DISPATCH-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576445#comment-16576445
 ] 

ASF GitHub Bot commented on DISPATCH-1099:
------------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/357#discussion_r209295809
  
    --- Diff: include/qpid/dispatch/router_core.h ---
    @@ -797,4 +799,9 @@ qdr_connection_info_t *qdr_connection_info(bool         
    is_encrypted,
                                                int              ssl_ssf,
                                                bool             ssl);
     
    +typedef struct qdr_timer_work_t qdr_timer_work_t;
    +typedef void (*qdr_timer_cb_t)(qdr_core_t *core, void* context);
    +qdr_timer_work_t *qdr_timer_schedule(qdr_core_t *core, qdr_timer_cb_t 
callback, void *timer_context, int timer_delay);
    +void qdr_timer_delete(qdr_core_t *core, qdr_timer_work_t *timer_work);
    --- End diff --
    
    Some comments on these function prototypes would be helpful?  What exactly 
does qdr_timer_delete do?  Should there be a qdr_timer_cancel()?


> Add a timer facility for the core thread
> ----------------------------------------
>
>                 Key: DISPATCH-1099
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1099
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>          Components: Container
>    Affects Versions: 1.2.0
>            Reporter: Ganesh Murthy
>            Assignee: Ganesh Murthy
>            Priority: Major
>
> Currently there is qd_router_timer_handler() in router_node.c which schedules 
> a timer every second/ Extend this to send the timer action into core so core 
> can execute some periodic actions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to