[
https://issues.apache.org/jira/browse/QPIDJMS-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644992#comment-16644992
]
ASF GitHub Bot commented on QPIDJMS-417:
----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/qpid-jms/pull/22
@gemmellr @tabish121 I'm not very proud to have exposed directly the
ByteBuf streams, but I have tried to use the right type on the facade and it
makes the code really unreadable (and confuse the mocking framework too!!) :(
```
<I extends InputStream & DataInput> I getInputStream() throws JMSException;
```
> Reduce GC pressure while using BytesMessage
> -------------------------------------------
>
> Key: QPIDJMS-417
> URL: https://issues.apache.org/jira/browse/QPIDJMS-417
> Project: Qpid JMS
> Issue Type: Improvement
> Components: qpid-jms-client
> Affects Versions: 0.37.0
> Reporter: Francesco Nigro
> Priority: Trivial
> Fix For: 0.38.0
>
>
> JmsBytesMessage::initializeReading() creates DataInputStream that allocates
> several byte[] and char[] even when no methods need them.
> Using directly the underline ByteBufInputStream would reduce the amount of
> garbage created while reducing the indirections needed to hit the underline
> ByteBuf that hold the data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
