[
https://issues.apache.org/jira/browse/QPIDJMS-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645094#comment-16645094
]
ASF GitHub Bot commented on QPIDJMS-417:
----------------------------------------
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-jms/pull/22
Can you elaborate on the benefits you measured here? I'd like to understand
the extent to consider against the downside of exposing dep impl types
throughout the code base.
The existing bits worked the way it did at least a small part because
BytesMessage specified thats where it gets its behaviours from. Are we sure
ByteBuf streams behave the same?
> Reduce GC pressure while using BytesMessage
> -------------------------------------------
>
> Key: QPIDJMS-417
> URL: https://issues.apache.org/jira/browse/QPIDJMS-417
> Project: Qpid JMS
> Issue Type: Improvement
> Components: qpid-jms-client
> Affects Versions: 0.37.0
> Reporter: Francesco Nigro
> Priority: Trivial
> Fix For: 0.38.0
>
>
> JmsBytesMessage::initializeReading() creates DataInputStream that allocates
> several byte[] and char[] even when no methods need them.
> Using directly the underline ByteBufInputStream would reduce the amount of
> garbage created while reducing the indirections needed to hit the underline
> ByteBuf that hold the data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]