Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/qpid-proton-j/pull/18#discussion_r225223601
  
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/ssl/DefaultSslEngineFacade.java
 ---
    @@ -36,7 +36,7 @@
         /**
          * Our testing has shown that application buffers need to be a bit 
larger
          * than that provided by {@link SSLSession#getApplicationBufferSize()} 
otherwise
    -     * {@link Status#BUFFER_OVERFLOW} will result on {@link 
SSLEngine#unwrap()}.
    +     * {@link Status#BUFFER_OVERFLOW} will result on {@link 
SSLEngine#unwrap)}.
    --- End diff --
    
    Seems to me like this change breaks the javadoc rather than fixing anything.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to