Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/qpid-proton-j/pull/18#discussion_r225266894
--- Diff:
examples/reactor/src/main/java/org/apache/qpid/proton/example/reactor/EchoInputStreamWrapper.java
---
@@ -31,11 +31,12 @@
public class EchoInputStreamWrapper extends Thread {
+ private static final AtomicInteger idCounter = new AtomicInteger();
--- End diff --
Since this is an example, it should show the "best practices". I do not
know what the best practices are, though. Inspiring people to use static
variables does not to be the right thing. What is there now is not right
either...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
