Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/qpid-proton-j/pull/18#discussion_r231105833
  
    --- Diff: 
proton-j/src/main/java/org/apache/qpid/proton/message/impl/MessageImpl.java ---
    @@ -49,11 +49,7 @@
           }
         }
     
    -    private static final ThreadLocal<EncoderDecoderPair> tlsCodec = new 
ThreadLocal<EncoderDecoderPair>() {
    -          @Override protected EncoderDecoderPair initialValue() {
    -            return new EncoderDecoderPair();
    -          }
    -      };
    +    private static final ThreadLocal<EncoderDecoderPair> tlsCodec = 
ThreadLocal.withInitial(EncoderDecoderPair::new);
    --- End diff --
    
    Well, I wouldn't have guessed this is not equivalent change. Another lesson 
in being conservative and not changing what is known to work without pressing 
reasons. (Previously I had a bad experience trying to upgrade JUnit version 
once, with random changes in test results.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to