ganeshmurthy commented on a change in pull request #439: DISPATCH-1214: remove
shutdown leak reported by Valgrind
URL: https://github.com/apache/qpid-dispatch/pull/439#discussion_r249841944
##########
File path: src/router_core/router_core.c
##########
@@ -173,6 +173,9 @@ void qdr_core_free(qdr_core_t *core)
free(link->insert_prefix);
free(link->strip_prefix);
link->name = 0;
+ for (int i = 0; i < QDR_LINK_LIST_CLASSES; ++i) {
+ free_qdr_link_ref_t(link->ref[i]);
Review comment:
instead of calling free_qdr_link_ref_t is it worth calling
bool qdr_del_link_ref(qdr_link_ref_list_t *ref_list, qdr_link_t *link, int
cls)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
