k-wall opened a new pull request #30: PROTON-1998: Add SASL protocol trace URL: https://github.com/apache/qpid-proton-j/pull/30 This patch adds a SASL protocol trace that is controlled by the same mechanism as the main protocol trace. Could you comment on the approach? If it is acceptable, I'll add some tests. One unsettled question in my mind ProtocolTracer: at the moment, ProtocolTracer implementations don't receive SaslFrameBodies. I did as this would break ProtocolTracer impls (including QpidJMS's - which would ClassCastException). I wondered using a default method ProtocolTracer#ignoreSaslFrameBody which would return true. Comments appreciated..
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
