ChugR commented on a change in pull request #445: DISPATCH-1246: clean up core
link endpoints on shutdown
URL: https://github.com/apache/qpid-dispatch/pull/445#discussion_r252745594
##########
File path: src/router_core/connections.c
##########
@@ -1227,9 +1223,7 @@ static void qdr_connection_closed_CT(qdr_core_t *core,
qdr_action_t *action, boo
qdr_connection_work_t *work = DEQ_HEAD(conn->work_list);
while (work) {
DEQ_REMOVE_HEAD(conn->work_list);
- qdr_terminus_free(work->source);
- qdr_terminus_free(work->target);
- free_qdr_connection_work_t(work);
+ qdr_connection_work_free_CT(work);
Review comment:
I'm running a Debug build. This error does not happen on every run. Also,
I'm seeing an occasional failure with an assert link_route_proxy.c#371, a lrp
pointer points to a proxy with bad proxy_state.
Attached are two files that have the grinder result from two runs only of
system_tests_edge_router.
- grinder-at-1246.txt has the bad memory reference and the assert.
- grinder-at-1246-2.txt has no bad reference, no assert, and a varying set
of object leaks.
[grinder-at-1246.txt](https://github.com/apache/qpid-dispatch/files/2818175/grinder-at-1246.txt)
[grinder-at-1246-2.txt](https://github.com/apache/qpid-dispatch/files/2818176/grinder-at-1246-2.txt)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
