[ 
https://issues.apache.org/jira/browse/PROTON-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758163#comment-16758163
 ] 

ASF GitHub Bot commented on PROTON-1998:
----------------------------------------

gemmellr commented on issue #30: PROTON-1998: Add SASL protocol trace
URL: https://github.com/apache/qpid-proton-j/pull/30#issuecomment-459672396
 
 
   Though I may have at the outset, I don't think I'd go this way with 
adjustment of TransportFrame at this point.
   
   Given that the ProtocolTracer adds new methods to convey SASL details, and 
the non-tracer output specifically handles SASL output separately to begin 
with, I think the original bits are probably best left as is and simple 
addition made for the SASL bits (e.g a new package private transport log 
method). SASL frames also dont have a channel or payload so in this case a 
TransportFrame object is always just being used to carry the performative as 
the only detail, so the new ProtocolTracer methods could just pass that.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Proton-J] Add SASL protocol trace
> ----------------------------------
>
>                 Key: PROTON-1998
>                 URL: https://issues.apache.org/jira/browse/PROTON-1998
>             Project: Qpid Proton
>          Issue Type: Improvement
>          Components: proton-j
>            Reporter: Keith Wall
>            Priority: Minor
>
> Unlike Proton, Proton-J does not provide SASL frame trace if environment 
> variable PN_TRACE_FRM is set.  It would be useful if Proton-J had this 
> ability too to help diagnose SASL negotiation problem.
> Proton's SASL frame trace looks like this:
> {code:java}
> [0x7fc112c03a00]: -> SASL
> [0x7fc112c03a00]: <- SASL
> [0x7fc112c03a00]:0 <- @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS]]
> [0x7fc112c03a00]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS, 
> initial-response=b"guest@Oslo.local"]
> [0x7fc112c03a00]:0 <- @sasl-outcome(68) [code=0]
> [0x7fc112c03a00]: -> AMQP
> [0x7fc112c03a00]:0 -> @open(16) 
> [container-id="be777c26-af6e-4935-a6be-316cc8bbdb35", hostname="127.0.0.1", 
> channel-max=32767]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to