[
https://issues.apache.org/jira/browse/DISPATCH-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785880#comment-16785880
]
ASF GitHub Bot commented on DISPATCH-1278:
------------------------------------------
grs commented on pull request #453: DISPATCH-1278: initial support for
prometheus metrics export
URL: https://github.com/apache/qpid-dispatch/pull/453#discussion_r263044058
##########
File path: src/http-libwebsockets.c
##########
@@ -361,6 +386,135 @@ static void connection_wake(qd_connection_t *qd_conn)
}
}
+static void handle_stats_results(void *context, qdr_global_stats_t *results)
+{
+ stats_t* stats = (stats_t*) context;
+ qd_http_server_t *hs = stats->server;
+ if (hs) {
+ work_t w = { W_HANDLE_STATS, stats->wsi };
+ work_push(hs, w);
Review comment:
I believe the nature of the interaction means this will never happen. Each
request uses a separate instance of the counters. Only the core thread updates
those counters and they are only read by the http thread once the core thread
has made the callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for prometheus metrics export
> -----------------------------------------
>
> Key: DISPATCH-1278
> URL: https://issues.apache.org/jira/browse/DISPATCH-1278
> Project: Qpid Dispatch
> Issue Type: New Feature
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Major
> Fix For: 1.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
