[
https://issues.apache.org/jira/browse/DISPATCH-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786212#comment-16786212
]
ASF GitHub Bot commented on DISPATCH-1278:
------------------------------------------
grs commented on issue #453: DISPATCH-1278: initial support for prometheus
metrics export
URL: https://github.com/apache/qpid-dispatch/pull/453#issuecomment-470316480
I've updated the patch to move the callback on to the general work queue as
suggested.
I've also made it work with older versions of libwebsockets (due to
DISPATCH-1280).
One aspect of supporting the older libwebsockets api is that I can't use the
lws_add_http_common_headers method (not available before 3 it seems). That
function allowed the content length to be omitted (meaning we can stream the
data rather than buffering it all before sending it) and marked the connection
to be closed at the end of the data. Without this clients may wait for more
data. I have tested with prometheus and it seems to cope with this fine. When
testing with a web browser though there appears to be a one or two second delay
in displaying the results.
One option is to add explicit chunking (libwebsockets has no built in
support for that but it should be easy enough). Alternatively once
DISPATCH-1280 is fixed we could require the later websockets library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for prometheus metrics export
> -----------------------------------------
>
> Key: DISPATCH-1278
> URL: https://issues.apache.org/jira/browse/DISPATCH-1278
> Project: Qpid Dispatch
> Issue Type: New Feature
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Major
> Fix For: 1.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
