ted-ross commented on a change in pull request #455: DISPATCH-1275 - Enabled
deletion of connections based on connection i…
URL: https://github.com/apache/qpid-dispatch/pull/455#discussion_r263110299
##########
File path: src/router_core/agent.c
##########
@@ -414,7 +414,7 @@ static void qdr_manage_delete_CT(qdr_core_t *core,
qdr_action_t *action, bool di
case QD_ROUTER_CONFIG_ADDRESS: qdra_config_address_delete_CT(core,
query, name, identity); break;
case QD_ROUTER_CONFIG_LINK_ROUTE: qdra_config_link_route_delete_CT(core,
query, name, identity); break;
case QD_ROUTER_CONFIG_AUTO_LINK: qdra_config_auto_link_delete_CT(core,
query, name, identity); break;
- case QD_ROUTER_CONNECTION: break;
+ case QD_ROUTER_CONNECTION: qdra_connection_delete_CT(core, query,
identity); break; //Connection objects are created by the router and they have
an id and no name
Review comment:
The forced closing of a connection is supposed to be signalled by setting
the adminStatus to "deleted", not by using the DELETE method in AMQP management.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
