ChugR commented on a change in pull request #472: Dispatch 1288 1 - policy for 
outbound connectors
URL: https://github.com/apache/qpid-dispatch/pull/472#discussion_r268183135
 
 

 ##########
 File path: src/policy.c
 ##########
 @@ -1110,6 +1152,62 @@ void qd_policy_amqp_open(qd_connection_t *qd_conn) {
 }
 
 
+void qd_policy_amqp_open_connector(qd_connection_t *qd_conn) {
 
 Review comment:
   I'm leaving the name as-is. It looks good at the call site in container.c.
   
   There are two hard problems in software engineering: cache invalidation, 
naming things, and off-by-one errors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to