ted-ross commented on a change in pull request #502: DISPATCH-1326 - Handling
of anonymous messages sent to edge routers. …
URL: https://github.com/apache/qpid-dispatch/pull/502#discussion_r281826325
##########
File path: src/router_node.c
##########
@@ -1383,6 +1383,18 @@ static void CORE_link_second_attach(void *context,
qdr_link_t *link, qdr_terminu
//
pn_link_open(qd_link_pn(qlink));
+ qd_connection_t *conn = qd_link_connection(qlink);
+ qdr_connection_t *qdr_conn = (qdr_connection_t*)
qd_connection_get_context(conn);
+ //
+ // Anonymous sender links coming in on edge connections must not have an
q2 limit set. This will ensure
+ // that several senders connected to the edge and sending large messages
dont choke that link.
+ // Regular sending links on the edge router connection will still be
subjected to q2 back pressure.
+ //
+ if (link->link_direction == QD_INCOMING && qdr_conn->core->router_mode ==
QD_ROUTER_MODE_INTERIOR && qdr_conn->role == QDR_ROLE_EDGE_CONNECTION &&
link->owning_addr == 0) {
Review comment:
This conditional is too narrow. It should disable q2-limiting on any link
over an edge or inter-router connection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
