franz1981 commented on a change in pull request #510: DISPATCH-1343 Faster
qd_buffer and qd_message allocations
URL: https://github.com/apache/qpid-dispatch/pull/510#discussion_r287424668
##########
File path: include/qpid/dispatch/atomic.h
##########
@@ -203,6 +223,14 @@ static inline void sys_atomic_destroy(sys_atomic_t *ref)
sys_mutex_free(ref->lock);
}
+static inline void sys_atomic_release_fence()
+{
+ //it shoudn't leak any OS resources, because (unshared) spin locks
+ //are just user space atomic ints
+ sys_spinlock_t lock;
+ sys_spin_init(&lock);
Review comment:
This can be seen here:
https://github.com/lattera/glibc/blob/895ef79e04a953cac1493863bcae29ad85657ee1/sysdeps/x86_64/nptl/pthread_spin_unlock.S#L22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
