gemmellr commented on a change in pull request #30: QPIDJMS-461 Optimize the
default message ID builder
URL: https://github.com/apache/qpid-jms/pull/30#discussion_r294693305
##########
File path:
qpid-jms-client/src/main/java/org/apache/qpid/jms/policy/JmsDefaultMessageIDPolicy.java
##########
@@ -26,7 +26,15 @@
*/
public class JmsDefaultMessageIDPolicy implements JmsMessageIDPolicy {
- private JmsMessageIDBuilder messageIDBuilder =
JmsMessageIDBuilder.BUILTIN.DEFAULT.createBuilder();
+ /**
+ * A global builder instance to use instance of allocating one on each
builder get.
Review comment:
The second mention of 'instance' should be 'instead'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
