astitcher commented on a change in pull request #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr URL: https://github.com/apache/qpid-proton/pull/176#discussion_r306357395
########## File path: c/src/platform/platform.h ########## @@ -65,7 +65,7 @@ int pn_i_error_from_errno(pn_error_t *error, const char *msg); */ int64_t pn_i_atoll(const char* num); -int pni_snprintf(char *buf, size_t count, const char *fmt, ...); +PN_EXTERN int pni_snprintf(char *buf, size_t count, const char *fmt, ...); Review comment: Yes, those symbols are the subject of an issue (PROTON-1637) they should either be public API with a well defined meaning or not exported. pni == ProtoN Internal. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
