[
https://issues.apache.org/jira/browse/DISPATCH-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913551#comment-16913551
]
ASF GitHub Bot commented on DISPATCH-1266:
------------------------------------------
codecov-io commented on issue #554: DISPATCH-1266: Fix unsettled multicast
forwarding
URL: https://github.com/apache/qpid-dispatch/pull/554#issuecomment-524011262
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=h1)
Report
> Merging
[#554](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/c6fe7ec4dfe1fb0538c750932a812ccc43904f56?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `95.8%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #554 +/- ##
==========================================
+ Coverage 86.58% 86.59% +0.01%
==========================================
Files 88 88
Lines 19730 19827 +97
==========================================
+ Hits 17083 17169 +86
- Misses 2647 2658 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `93.42% <ø> (-0.14%)` | :arrow_down: |
|
[src/router\_core/core\_link\_endpoint.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfbGlua19lbmRwb2ludC5j)
| `97% <100%> (ø)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `92.76% <100%> (-0.24%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.34% <100%> (+0.22%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.15% <100%> (-0.32%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `88.46% <95%> (+0.6%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `88.97% <0%> (-0.17%)` | :arrow_down: |
| ... and [2
more](https://codecov.io/gh/apache/qpid-dispatch/pull/554/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=footer).
Last update
[c6fe7ec...7e1cc88](https://codecov.io/gh/apache/qpid-dispatch/pull/554?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve router's handling of unsettled multicast deliveries
> -----------------------------------------------------------
>
> Key: DISPATCH-1266
> URL: https://issues.apache.org/jira/browse/DISPATCH-1266
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Documentation, Management Agent, Routing Engine, Tests
> Affects Versions: 1.5.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
>
> The current implementation of multicast forwarding will immediately settle
> the delivery on ingress to the router and forward the delivery as pre-settled.
> This means the settlement state sent back to the producer provides no
> indication of actual delivery state. And the credit is replenished
> immediately rather than gate on the settlement coming from the consumer.
> Improve this behavior by settling of the inbound delivery after all outbound
> deliveries have settled.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
