[
https://issues.apache.org/jira/browse/DISPATCH-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913634#comment-16913634
]
ASF GitHub Bot commented on DISPATCH-1266:
------------------------------------------
ChugR commented on issue #554: DISPATCH-1266: Fix unsettled multicast forwarding
URL: https://github.com/apache/qpid-dispatch/pull/554#issuecomment-524043580
This patch @ 7e1cc88 is good.
* I ran the torture test with one sender and four receivers and a million
messages. All receivers received all messages.
* During the test I started dozens of receivers getting 1000 messages only.
They would connect, get messages from the million message stream, and then
disconnect. No problem with them nor with interference with the long-standing
receivers.
* Memory usage perfectly flat.
There was no performance testing here, just some sanity checking with
multiple network hops.
Ship it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve router's handling of unsettled multicast deliveries
> -----------------------------------------------------------
>
> Key: DISPATCH-1266
> URL: https://issues.apache.org/jira/browse/DISPATCH-1266
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Documentation, Management Agent, Routing Engine, Tests
> Affects Versions: 1.5.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
>
> The current implementation of multicast forwarding will immediately settle
> the delivery on ingress to the router and forward the delivery as pre-settled.
> This means the settlement state sent back to the producer provides no
> indication of actual delivery state. And the credit is replenished
> immediately rather than gate on the settlement coming from the consumer.
> Improve this behavior by settling of the inbound delivery after all outbound
> deliveries have settled.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
