alex-rufous commented on a change in pull request #34: QPID-7615 Number of selectors can be equal to connection thread pool size URL: https://github.com/apache/qpid-broker-j/pull/34#discussion_r323792710
########## File path: broker-core/src/test/java/org/apache/qpid/server/model/VirtualHostTest.java ########## @@ -509,31 +509,47 @@ public void testExistingConnectionBlocking() } @Test - public void testCreateValidation() + public void testSelectorNumberMustBePositiveOnCreate() { + createVirtualHost(getTestName(), Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "1")); Review comment: It make sense to verify that attribute "numberOfSelectors" is indeed set to the specified value, for example `Map<String, Object> attributes = Collections.singletonMap(QueueManagingVirtualHost.NUMBER_OF_SELECTORS, "1"); final QueueManagingVirtualHost<?> vh = createVirtualHost(getTestName(), attributes); assertEquals(1, vh.getNumberOfSelectors());` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org