ganeshmurthy commented on a change in pull request #565: DISPATCH-1417 - First 
attempt at fixing router crash by introducing a…
URL: https://github.com/apache/qpid-dispatch/pull/565#discussion_r324270123
 
 

 ##########
 File path: src/server.c
 ##########
 @@ -1011,7 +1012,9 @@ static void *thread_run(void *arg)
             /* Free the connection after all other processing is complete */
             if (qd_conn && pn_event_type(e) == PN_TRANSPORT_CLOSED) {
                 pn_connection_set_context(pn_conn, NULL);
+                sys_mutex_lock(qd_server->conn_activation_lock);
 
 Review comment:
   Added additional commit to narrow down the lock held to just the free of the 
qd_connection_t object and not the whole qd_connection_free() function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to