kgiusti commented on a change in pull request #578: DISPATCH-1434 - Added new
attribute saslPasswordFile to the connector…
URL: https://github.com/apache/qpid-dispatch/pull/578#discussion_r330577701
##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -1002,10 +1002,17 @@
"saslPassword": {
"type": "string",
"required": false,
- "description": "The password that the connector is using
to connect to a peer.",
+ "description": "(DEPRECATED) The password that the
connector is using to connect to a peer.",
Review comment:
Compare this to the text description for SSL's password. SSL Password's
description contains a bit more detail - can you update saslPassword's
description to be consistent?
> This attribute has been deprecated because it is unsafe to store plain
text passwords in config files. Use the passwordFile instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]