bhardesty commented on a change in pull request #581: DISPATCH-1442 - Added 
annotation field to the router entity.
URL: https://github.com/apache/qpid-dispatch/pull/581#discussion_r332123654
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -493,6 +493,12 @@
                     "create": true,
                     "required": false,
                     "default": "balanced"
+                },
+                "annotation": {
+                    "type": "string",
+                    "description": "Annotation text for this router, to be 
used by user or orchestration layers.",
 
 Review comment:
   How about this (I made some assumptions about the primary use case for 
providing an annotation, which may or may not be accurate):
   
   Optional annotation text to describe or label this router. This text does 
not affect the function of the router, but it can be used by external tools 
(such as the console or orchestration software) to control how the router is 
displayed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to