[ 
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948126#comment-16948126
 ] 

Roddie Kieley commented on PROTON-2105:
---------------------------------------

[~lulf] [~aconway] I've added a branch in the GitHub Apache Qpid Proton repo, 
[PROTON-2105-apache|https://github.com/apache/qpid-proton/tree/PROTON-2105-apache],
 which contains an updated go tree with a go.mod plus other required changes to 
source and markdown files. This removes the qpid.apache.org import magic in 
favour of the absolute and currently favoured with modules 
"github.com/apache/qpid-proton" module naming and package import references 
that look like "github.com/apache/qpid-proton/go/pkg/amqp" etc.

I've added a most basic GoLand project using this branch via a go.mod reference 
in my GitHub repo under 
[PROTON-2105-apache-project|https://github.com/RoddieKieley/PROTON-2105-apache-project]
 where the key piece is the 
[go.mod|https://github.com/RoddieKieley/PROTON-2105-apache-project/blob/master/go.mod]
 file which, after automatic GoLand processing looks like:
{code:java}
module PROTON-2105-apache-project
go 1.12
require github.com/apache/qpid-proton v0.0.0-20191010013420-0c20a4dfd1f7{code}
but started out like
{code:java}
module PROTON-2105-apache-project
go 1.12
require github.com/apache/qpid-proton PROTON-2105-apache{code}
to reference the branch.

In 
[main.go|https://github.com/RoddieKieley/PROTON-2105-apache-project/blob/master/main.go]
 I reference the amqp package via:
{code:java}
"github.com/apache/qpid-proton/go/pkg/amqp" {code}
 

Please give the 
[PROTON-2105-apache|https://github.com/apache/qpid-proton/tree/PROTON-2105-apache]
 branch a try when you get a chance and let me know if it works for you and 
anything you see that needs to be completed/changed/etc.

> Support Go modules
> ------------------
>
>                 Key: PROTON-2105
>                 URL: https://issues.apache.org/jira/browse/PROTON-2105
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: go-binding
>            Reporter: Ulf Lilleengen
>            Assignee: Roddie Kieley
>            Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage 
> dependencies using go modules, dependencies must also be using go modules. 
> Therefore, adding a go.mod file to each module would allow qpid proton go 
> bindings to be managed as a go module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to