[
https://issues.apache.org/jira/browse/PROTON-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962578#comment-16962578
]
Roddie Kieley commented on PROTON-2105:
---------------------------------------
As above I committed the work for the go module support. Locally all tests
pass, however I do note that in travis in the build *before* these commits,
2205, the [Xcode 10.1
variant|https://travis-ci.org/apache/qpid-proton/jobs/603007629] shows the
electron go-test TestHeartbeat failing:
{code}
26: === RUN TestHeartbeat
362126: --- FAIL: TestHeartbeat (0.49s)
362226: electron_test.go:325: connection failed to time out
{code}
The commits did not change the state with the tests still only failing for the
subsequent 2206 build job in the [Xcode 10.1
variant|https://travis-ci.org/apache/qpid-proton/jobs/604743078] for the same
reason:
{code}
26: === RUN TestHeartbeat
363926: --- FAIL: TestHeartbeat (0.41s)
364026: electron_test.go:325: connection failed to time out
{code}
As this appears unrelated to the committed work I will mark this complete.
> Support Go modules
> ------------------
>
> Key: PROTON-2105
> URL: https://issues.apache.org/jira/browse/PROTON-2105
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
> Reporter: Ulf Lilleengen
> Assignee: Roddie Kieley
> Priority: Major
>
> As of Go 1.12, go module support is available. In order to manage
> dependencies using go modules, dependencies must also be using go modules.
> Therefore, adding a go.mod file to each module would allow qpid proton go
> bindings to be managed as a go module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
