astitcher commented on a change in pull request #192: Changed Python API to
better handle strings where symbo…
URL: https://github.com/apache/qpid-proton/pull/192#discussion_r334082424
##########
File path: python/proton/_endpoints.py
##########
@@ -500,6 +500,79 @@ def free(self):
"""
pn_connection_release(self._impl)
+ def _get_offered_capabilities(self):
+ return self.offered_capabilities_list
+ def _set_offered_capabilities(self, offered_capability_list):
+ if isinstance(offered_capability_list, list):
+ self.offered_capabilities_list =
SymbolList(offered_capability_list, throw=False)
+ else:
+ self.offered_capabilities_list = offered_capability_list
Review comment:
Please, please ,please follow the usual Python formatting standards (PEP8).
Running functions into each other like this makes the code unreadable to many
python coders (myself included)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
