ChugR commented on a change in pull request #600: DISPATCH-1463 - Add detection
for stuck deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#discussion_r339736259
##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -570,6 +570,11 @@
"graph": true,
"description": "The total number of settled deliveries
that were held in the router for more than 10 seconds."
},
+ "deliveriesStuck": {
+ "type": "integer",
+ "graph": true,
+ "description": "The current number of deliveries that are
unsettled and have been held in the router for more than 10 seconds."
+ },
Review comment:
Would you consider a 'peakDeliveriesStuck' stat?
Picture a network where some clients go down and zillions of deliveries get
stuck. Then those clients come back and the stuck number goes to zero. This
would provide some indication of an issue even though the current state is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
