[
https://issues.apache.org/jira/browse/DISPATCH-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961453#comment-16961453
]
ASF GitHub Bot commented on DISPATCH-1463:
------------------------------------------
codecov-io commented on issue #600: DISPATCH-1463 - Add detection for stuck
deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#issuecomment-546504990
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=h1)
Report
> Merging
[#600](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/d37ee8c3ae0344e462d816c90db8a915588c2b1d?src=pr&el=desc)
will **increase** coverage by `0.05%`.
> The diff coverage is `97.7%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 86.39% 86.44% +0.05%
==========================================
Files 90 91 +1
Lines 20495 20579 +84
==========================================
+ Hits 17707 17790 +83
- Misses 2788 2789 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.88% <100%> (+0.15%)` | :arrow_up: |
|
[src/router\_core/router\_core\_thread.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlX3RocmVhZC5j)
| `100% <100%> (ø)` | :arrow_up: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `88.53% <100%> (+0.06%)` | :arrow_up: |
|
[src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==)
| `67.16% <100%> (+0.33%)` | :arrow_up: |
|
[src/router\_core/agent\_router.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X3JvdXRlci5j)
| `90.58% <100%> (+0.22%)` | :arrow_up: |
|
[...odules/stuck\_delivery\_detection/delivery\_tracker.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvc3R1Y2tfZGVsaXZlcnlfZGV0ZWN0aW9uL2RlbGl2ZXJ5X3RyYWNrZXIuYw==)
| `96.61% <96.61%> (ø)` | |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `90.99% <0%> (-0.4%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.09% <0%> (-0.12%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (-0.02%)` | :arrow_down: |
| ... and [2
more](https://codecov.io/gh/apache/qpid-dispatch/pull/600/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=footer).
Last update
[d37ee8c...711172c](https://codecov.io/gh/apache/qpid-dispatch/pull/600?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Detect deliveries that are stuck in the router for a long time
> --------------------------------------------------------------
>
> Key: DISPATCH-1463
> URL: https://issues.apache.org/jira/browse/DISPATCH-1463
> Project: Qpid Dispatch
> Issue Type: New Feature
> Components: Router Node
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.10.0
>
>
> The delayed-delivery counts are limited in that they only count deliveries
> that have been settled. These counters do not count deliveries that are
> currently "stuck" and have not been settled.
> This feature provides visibility into the number of stuck deliveries per link
> and per router.
> A new counter "deliveriesStuck" shall be added to the link and router
> entities for per-link and aggregated-per-router respectively.
> A delivery is considered "stuck" when it has been in the undelivered or
> unsettled lists for more than ten seconds and is still not settled. Once a
> stuck delivery is settled or otherwise removed, it is no longer considered
> stuck.
> When a link transitions from zero to one stuck delivery, an INFO log message
> shall be emitted indicating that at least one delivery is stuck on that link.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
