[ 
https://issues.apache.org/jira/browse/DISPATCH-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16962003#comment-16962003
 ] 

ASF GitHub Bot commented on DISPATCH-1463:
------------------------------------------

ted-ross commented on pull request #600: DISPATCH-1463 - Add detection for 
stuck deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#discussion_r340068152
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -570,6 +570,11 @@
                     "graph": true,
                     "description": "The total number of settled deliveries 
that were held in the router for more than 10 seconds."
                 },
+                "deliveriesStuck": {
+                    "type": "integer",
+                    "graph": true,
+                    "description": "The current number of deliveries that are 
unsettled and have been held in the router for more than 10 seconds."
+                },
 
 Review comment:
   Do we need this?  INFO logs are issued when a link has stuck deliveries and 
the count is available through the prometheus-format scraper.
   Since this is more of a gauge than a counter, having a peak value might be 
appropriate.  Would it also require a way to be reset?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Detect deliveries that are stuck in the router for a long time
> --------------------------------------------------------------
>
>                 Key: DISPATCH-1463
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1463
>             Project: Qpid Dispatch
>          Issue Type: New Feature
>          Components: Router Node
>            Reporter: Ted Ross
>            Assignee: Ted Ross
>            Priority: Major
>             Fix For: 1.10.0
>
>
> The delayed-delivery counts are limited in that they only count deliveries 
> that have been settled.  These counters do not count deliveries that are 
> currently "stuck" and have not been settled.
> This feature provides visibility into the number of stuck deliveries per link 
> and per router.
> A new counter "deliveriesStuck" shall be added to the link and router 
> entities for per-link and aggregated-per-router respectively.
> A delivery is considered "stuck" when it has been in the undelivered or 
> unsettled lists for more than ten seconds and is still not settled.  Once a 
> stuck delivery is settled or otherwise removed, it is no longer considered 
> stuck.
> When a link transitions from zero to one stuck delivery, an INFO log message 
> shall be emitted indicating that at least one delivery is stuck on that link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to