ted-ross commented on a change in pull request #600: DISPATCH-1463 - Add 
detection for stuck deliveries
URL: https://github.com/apache/qpid-dispatch/pull/600#discussion_r340068152
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -570,6 +570,11 @@
                     "graph": true,
                     "description": "The total number of settled deliveries 
that were held in the router for more than 10 seconds."
                 },
+                "deliveriesStuck": {
+                    "type": "integer",
+                    "graph": true,
+                    "description": "The current number of deliveries that are 
unsettled and have been held in the router for more than 10 seconds."
+                },
 
 Review comment:
   Do we need this?  INFO logs are issued when a link has stuck deliveries and 
the count is available through the prometheus-format scraper.
   Since this is more of a gauge than a counter, having a peak value might be 
appropriate.  Would it also require a way to be reset?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to