jdanekrh commented on a change in pull request #180: PROTON-2030 Use
CLOCK_MONOTONIC in proactors for pn_transport_tick
URL: https://github.com/apache/qpid-proton/pull/180#discussion_r341068567
##########
File path: c/src/proactor/win_iocp.c
##########
@@ -3427,11 +3414,9 @@ const pn_netaddr_t *pn_listener_addr(pn_listener_t *l) {
}
pn_millis_t pn_proactor_now(void) {
- FILETIME now;
- GetSystemTimeAsFileTime(&now);
- ULARGE_INTEGER t;
- t.u.HighPart = now.dwHighDateTime;
- t.u.LowPart = now.dwLowDateTime;
- // Convert to milliseconds and adjust base epoch
- return t.QuadPart / 10000 - 11644473600000;
+ return (pn_millis_t) pn_proactor_now_64();
+}
+
+int64_t pn_proactor_now_64(void) {
Review comment:
@astitcher So you you think that pn_proactor_now whould return signed or
unsigned value? Because one response given your comments could be to just go
unsigned everywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
