[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969025#comment-16969025
]
ASF GitHub Bot commented on DISPATCH-1439:
------------------------------------------
ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes
to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343517080
##########
File path: src/router_core/router_core_private.h
##########
@@ -659,6 +659,9 @@ struct qdr_connection_t {
qdr_conn_admin_status_t admin_status;
qdr_error_t *error;
bool closed; // This bit is used in the case where
a client is trying to force close this connection.
+ uint32_t conn_uptime; // The number of seconds that
this connection has been up and running.
+ uint32_t last_delivery_time; // The number of seconds
since the last delivery arrived on this connection.
+ bool is_delivery_sent;
Review comment:
Couldn't this boolean be avoided by saying that last_delivery_time == 0 if
no deliveries have been sent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Expose create time/last transfer time through the Connection management entity
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Keith Wall
> Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
