[
https://issues.apache.org/jira/browse/DISPATCH-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969170#comment-16969170
]
ASF GitHub Bot commented on DISPATCH-1439:
------------------------------------------
ted-ross commented on pull request #614: DISPATCH-1439 - Added two attributes
to connection and one to router.
URL: https://github.com/apache/qpid-dispatch/pull/614#discussion_r343593410
##########
File path: python/qpid_dispatch_internal/tools/display.py
##########
@@ -45,7 +45,14 @@ def Commas(value):
sval = left
def TimeLong(value):
- return strftime("%c", gmtime(value / 1000000000))
+ day = value // (24 * 3600)
+ time = value % (24 * 3600)
+ hour = time // 3600
+ time %= 3600
+ minutes = time // 60
+ time %= 60
+ seconds = time
+ return "%03d:%02d:%02d:%02d" % (day, hour, minutes, seconds)
Review comment:
I'm curious as to why this was done. Does the strftime function no format
the data properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Expose create time/last transfer time through the Connection management entity
> ------------------------------------------------------------------------------
>
> Key: DISPATCH-1439
> URL: https://issues.apache.org/jira/browse/DISPATCH-1439
> Project: Qpid Dispatch
> Issue Type: Improvement
> Reporter: Keith Wall
> Priority: Major
>
> Having these two additional attributes:
> * connection create time
> * connection last transfer time
> would aid fault finding activities.
> It would also serve as useful input to external tooling wishing to say,
> balance connections to a router network.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
