kgiusti commented on a change in pull request #619: DISPATCH-1480: properly
settle messages received by the edge address …
URL: https://github.com/apache/qpid-dispatch/pull/619#discussion_r346868641
##########
File path: src/router_core/modules/edge_router/addr_proxy.c
##########
@@ -460,8 +461,14 @@ static void on_transfer(void *link_context,
qd_parse_free(body);
qd_iterator_free(iter);
+ } else {
+ qd_log(ap->core->log, QD_LOG_WARNING,
+ "Edge Address Proxy: received an invalid message body,
rejecting");
+ dispo = PN_REJECTED;
}
+ qdrc_endpoint_settle_CT(ap->core, dlv, dispo);
Review comment:
Turns out that all messages sent to this client are PRE-settled, so setting
the disposition to PN_REJECTED is harmless.
I think this patch is good to go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
