ganeshmurthy commented on a change in pull request #623: DISPATCH-1186: Add
option to get CSV formatting for qdstat tables
URL: https://github.com/apache/qpid-dispatch/pull/623#discussion_r348887033
##########
File path: tests/system_tests_qdstat.py
##########
@@ -73,25 +73,54 @@ def test_general(self):
self.assertTrue("Mode standalone" in out)
self.assertEqual(out.count("QDR.A"), 2)
+ def test_general_csv(self):
+ out = self.run_qdstat(['--general', '--csv'], r'(?s)Router
Statistics.*Mode","Standalone')
+ self.assertTrue("Connections","1" in out)
+ self.assertTrue("Nodes","0" in out)
+ self.assertTrue("Auto Links","0" in out)
+ self.assertTrue("Link Routes","0" in out)
+ self.assertTrue("Router Id","QDR.A" in out)
+ self.assertTrue("Mode","standalone" in out)
+ self.assertEqual(out.count("QDR.A"), 2)
+
def test_connections(self):
self.run_qdstat(['--connections'], r'host.*container.*role')
outs = self.run_qdstat(['--connections'], 'no-auth')
outs = self.run_qdstat(['--connections'], 'QDR.A')
+ def test_connections_csv(self):
+ self.run_qdstat(['--connections', "--csv"], r'host.*container.*role')
+ outs = self.run_qdstat(['--connections'], 'no-auth')
+ outs = self.run_qdstat(['--connections'], 'QDR.A')
+
def test_links(self):
self.run_qdstat(['--links'], r'QDR.A')
out = self.run_qdstat(['--links'], r'endpoint.*out.*local.*temp.')
parts = out.split("\n")
self.assertEqual(len(parts), 9)
+ def test_links_csv(self):
+ self.run_qdstat(['--links', "--csv"], r'QDR.A')
+ out = self.run_qdstat(['--links'], r'endpoint.*out.*local.*temp.')
+ parts = out.split("\n")
+ self.assertEqual(len(parts), 9)
+
def test_links_with_limit(self):
out = self.run_qdstat(['--links', '--limit=1'])
parts = out.split("\n")
self.assertEqual(len(parts), 8)
+ def test_links_with_limit_csv(self):
+ out = self.run_qdstat(['--links', '--limit=1', "--csv"])
+ parts = out.split("\n")
+ self.assertEqual(len(parts), 7)
+
def test_nodes(self):
self.run_qdstat(['--nodes'], r'No Router List')
+ def test_nodes_csv(self):
Review comment:
can we please add tests that test the csv output of --all-routers and
--all-entities ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
