[ 
https://issues.apache.org/jira/browse/DISPATCH-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979443#comment-16979443
 ] 

ASF GitHub Bot commented on DISPATCH-1491:
------------------------------------------

codecov-io commented on issue #626: DISPATCH-1491: use sets rather than 
iterating over lists
URL: https://github.com/apache/qpid-dispatch/pull/626#issuecomment-557194606
 
 
   # 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=h1) 
Report
   > Merging 
[#626](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/40303c20834ab4ec8ef8c1c8afa548b29c8a13da?src=pr&el=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/qpid-dispatch/pull/626/graphs/tree.svg?width=650&token=rk2Cgd27pP&height=150&src=pr)](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #626      +/-   ##
   ==========================================
   - Coverage   86.44%   86.41%   -0.03%     
   ==========================================
     Files          91       91              
     Lines       20625    20625              
   ==========================================
   - Hits        17830    17824       -6     
   - Misses       2795     2801       +6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/626/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
 | `93.36% <0%> (-0.74%)` | :arrow_down: |
   | 
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/626/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
 | `86.35% <0%> (-0.2%)` | :arrow_down: |
   | 
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/626/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
 | `89.17% <0%> (-0.17%)` | :arrow_down: |
   | 
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/626/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
 | `94.09% <0%> (-0.12%)` | :arrow_down: |
   | 
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/626/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==)
 | `90.9% <0%> (-0.01%)` | :arrow_down: |
   | 
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/626/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
 | `93.09% <0%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=footer).
 Last update 
[40303c2...aa9e323](https://codecov.io/gh/apache/qpid-dispatch/pull/626?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> bottleneck adding or removing addresses in mobile address engine
> ----------------------------------------------------------------
>
>                 Key: DISPATCH-1491
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1491
>             Project: Qpid Dispatch
>          Issue Type: New Feature
>          Components: Routing Engine
>    Affects Versions: 1.9.0
>            Reporter: Gordon Sim
>            Assignee: Gordon Sim
>            Priority: Major
>             Fix For: 1.10.0
>
>
> When a large number of addresses exist, adding or removing addresses in the 
> mobile address engine becomes increasingly expensive. This has the knock on 
> effect of preventing other general work from being scheduled (e.g. probes and 
> management queries)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to