[
https://issues.apache.org/jira/browse/DISPATCH-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979581#comment-16979581
]
ASF GitHub Bot commented on DISPATCH-1491:
------------------------------------------
grs commented on pull request #626: DISPATCH-1491: use sets rather than
iterating over lists
URL: https://github.com/apache/qpid-dispatch/pull/626#discussion_r349290275
##########
File path: python/qpid_dispatch_internal/router/mobile.py
##########
@@ -54,43 +54,44 @@ def tick(self, now):
if len(self.added_addrs) > 0 or len(self.deleted_addrs) > 0:
self.mobile_seq += 1
hints = [self.treatments[a] for a in self.added_addrs]
- msg = MessageMAU(None, self.id, self.mobile_seq, self.added_addrs,
self.deleted_addrs, _hints=hints)
+ msg = MessageMAU(None, self.id, self.mobile_seq,
list(self.added_addrs), list(self.deleted_addrs), _hints=hints)
self.sent_deltas[self.mobile_seq] = msg
if len(self.sent_deltas) > MAX_KEPT_DELTAS:
self.sent_deltas.pop(self.mobile_seq - MAX_KEPT_DELTAS)
self.container.send('amqp:/_topo/0/all/qdrouter.ma', msg)
self.container.log_ma(LOG_TRACE, "SENT: %r" % msg)
- self.local_addrs.extend(self.added_addrs)
+ for addr in self.added_addrs:
Review comment:
So altered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> bottleneck adding or removing addresses in mobile address engine
> ----------------------------------------------------------------
>
> Key: DISPATCH-1491
> URL: https://issues.apache.org/jira/browse/DISPATCH-1491
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Routing Engine
> Affects Versions: 1.9.0
> Reporter: Gordon Sim
> Assignee: Gordon Sim
> Priority: Major
> Fix For: 1.10.0
>
>
> When a large number of addresses exist, adding or removing addresses in the
> mobile address engine becomes increasingly expensive. This has the knock on
> effect of preventing other general work from being scheduled (e.g. probes and
> management queries)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
