astitcher commented on a change in pull request #213: PROTON-2140: Lazy
creation of various link related objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349298718
##########
File path: c/src/core/engine.c
##########
@@ -2299,7 +2314,11 @@ int pn_condition_copy(pn_condition_t *dest,
pn_condition_t *src) {
assert(src);
int err = 0;
if (src != dest) {
+ if (src->name == NULL) src->name = pn_string(NULL);
Review comment:
FWIW `pn_string_copy()` will cope correctly with NULL `src->name` string
(but not NULL `dest->name`).
Perhaps if src is NULL and if dest is not NULL the `dest->name` should be
freed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
