[ 
https://issues.apache.org/jira/browse/PROTON-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980155#comment-16980155
 ] 

Robbie Gemmell commented on PROTON-2141:
----------------------------------------

I'll leave review to someone with more of a clue about cpp bits, however...

Please include the JIRA key in your commits log (e.g: see existing PRs like 
https://github.com/apache/qpid-proton/pull/213 and commits: 
https://github.com/apache/qpid-proton/commits/master). That way the PR will be 
linked automatically and comments will be relayed to the JIRA automatically, 
and you dont need to manually add comments pointing to it etc, plus if/when the 
PR is merged the JIRA will then be automatically updated with note of the 
commits made.

> [cpp] Make unit tests pass on ipv4 machine
> ------------------------------------------
>
>                 Key: PROTON-2141
>                 URL: https://issues.apache.org/jira/browse/PROTON-2141
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: cpp-binding
>    Affects Versions: proton-c-0.29.0
>            Reporter: Rabih Mourad
>            Priority: Major
>
> There are test failure when running unit tests on an ipv4 machine.
> So we propose the pull request below.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to