ted-ross commented on a change in pull request #636: DISPATCH-1496: Reset link 
variables after the drain is complete. Also…
URL: https://github.com/apache/qpid-dispatch/pull/636#discussion_r353296483
 
 

 ##########
 File path: src/router_node.c
 ##########
 @@ -1531,8 +1531,11 @@ static void CORE_link_drained(void *context, qdr_link_t 
*link)
 
     pn_link_t *plink = qd_link_pn(qlink);
 
-    if (plink)
+    if (plink) {
         pn_link_drained(plink);
+        link->drain_mode = false;
+        link->credit_to_core = 0;
 
 Review comment:
   Are these operations safe to do here?  This function is invoked on an IO 
thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to